Stamp build_info and mark reserved-always-zero series as reserved - #64
Merged
Merged
Conversation
Nothing called SetBuildInfo, so /metrics always rendered empty build labels next to a correctly stamped version subcommand. Wire the package vars into the registry at boot, pin the rendering with a test, and stop presenting never-incremented series as actionable alerts in the README. Fixes #62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for operators?
/metricsepmon_build_infonow carries the release version/commit (was always empty) so dashboards can correlate behavior with builds. README marks the five never-incremented series (plus queue gauges) as reserved-for-future-use instead of actionable — no renames, no removals, names stay compat surface.Failing-then-passing test
New
TestBuildInfopins the stamped rendering; the wiring gap (main never calledSetBuildInfo) is verified live below before merge: boot dev binary,build_infoshows empty labels on main code vsdev/unknownwith the fix.Checklist
go build ./... && go vet ./... && go test ./...green with-race(metrics + cmd; full suite at merge)gofmt -l .cleanFixes #62