Wire validated config knobs into the runtime or remove them - #60
Merged
Merged
Conversation
Server timeouts reach the http.Server; probes.concurrency bounds fleet probe concurrency via semaphore; probes.max_body_bytes resolves onto each service and governs body inspection; storage.busy_timeout_ms travels in the SQLite DSN pragma; api.max_page_size caps paging (via #25). Removed unread keys (storage.path/retention/write_timeout, api.rate_limit) fail loudly at load; reserved future knobs (logging, auto_*, status_page, metrics auth) warn when explicitly set. Fixes #18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for operators?
Validated settings finally take effect: HTTP timeouts, probe concurrency, body-inspection cap, SQLite busy budget, page-size cap. Removed dead keys (
storage.path/retention/write_timeout,api.rate_limit) now fail loudly instead of being accepted-and-ignored — check configs; none of the shipped docs/examples set them. Explicitly-set-but-unimplemented knobs (logging, auto incidents/resolve, status page, metrics auth) warn on load instead of pretending to work.Failing-then-passing test
Per knob: server-timeout propagation, DSN pragma render + live
PRAGMA busy_timeoutreadback, body-cap needle-past-cap, semaphore contention cap (5 loops, max 2 inside), removed-key rejection, resolution test. Main-code contrasts measured (5 concurrent probes; capped needle matched). Suite green with-raceexcept the known main sqlite flake (fixed by #32). Merge notes: touchesProbenear #19,runDefaultnear #21/#27,loop()near #3/#29,warnOncefduplicated with #23 (keep either) — rebase order #23 first is cleanest.Checklist
go build ./... && go vet ./... && go test ./...green except pre-existing main flake (with-race)gofmt -l .cleanFixes #18