discojs documentation update - #1228
Merged
Merged
Conversation
JulienVig
approved these changes
Sep 23, 2026
JulienVig
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the updates! I left a few minor comments, feel free to merge when they're addressed
leonard-amsler
force-pushed
the
dicojs-doc-clarification
branch
2 times, most recently
from
September 28, 2026 15:05
c9d5da7 to
d21bf21
Compare
leonard-amsler
force-pushed
the
dicojs-doc-clarification
branch
from
September 28, 2026 15:08
d21bf21 to
635943e
Compare
leonard-amsler
marked this pull request as ready for review
September 28, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation of discojs is no longer aligned with the codebase. Classes no longer exist (DistributedTrainer, LocalTrainer), methods are renamed (fit becomes train) and outdated aggregators. No code change in this PR.
Changes:
Trainer:
Client:
Aggregators:
Disco:
Memory: