Conversation
Replaces env_logger with pyo3-log so log records from hypersync-client show up under the hypersync_client logger in Python. Closes enviodev#45.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Python extension now forwards Rust logs through Python’s ChangesLogging integration
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant Python as Python logging
participant Hypersync as hypersync module
participant Rust as Rust core
Python->>Hypersync: import module
Hypersync->>Python: initialize pyo3-log forwarding
Rust->>Python: emit log record
Python-->>Python: route record to configured handlers
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The logging bridge can be merged with normal checks; no concrete current-head issue remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Tools execution failed with the following error: Failed to run tools: 14 UNAVAILABLE: Connection dropped Comment |
Swaps env_logger for pyo3-log as suggested in the thread, so records from hypersync-client land on the hypersync_client logger and can be handled with normal Python logging config. Closes #45.
Summary by CodeRabbit
New Features
loggingmodule.Documentation