Repository navigation
fix: m_bDrawPlayerLegs saved in base player datadesc - #377
Merged
1upD merged 1 commit intoNov 9, 2026
Merged
Conversation
Blixibon
approved these changes
Nov 5, 2026
Blixibon
left a comment
Blixibon
left a comment
Collaborator
There was a problem hiding this comment.
I'll have to open a PR for this on Mapbase as well 🥴 (if you don't get to it first)
Author
I think I can do that, no worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current 2.0 build with Mapbase 8, if the player turns on the setting for "Show Visible Legs", the player can look down and see a first person legs model. However, if you save the game and then load a save, the visible legs disappear regardless of the setting.
This bug is caused because the variable
m_bDrawPlayerLegsis not saved in the player dataa description and so it resets to false when the game is loaded.This PR fixes the bug by adding that variable to its class' data description.
Does this PR close any issues?
PR Checklist
developbranch OR targets another branch with a specific goal in mind