Skip to content

Fix incorrect damage scaling behavior in CPropDrivableAPC::OnTakeDamage - #334

Closed
TankNut wants to merge 1 commit into
entropy-zero:ez2/mapbasefrom
TankNut:apc_damage_fix
Closed

TankNut wants to merge 1 commit into
entropy-zero:ez2/mapbasefrom
TankNut:apc_damage_fix

Conversation

@TankNut

@TankNut TankNut commented Mar 20, 2025

Copy link
Copy Markdown

This resolves an issue with EZ's version of vehicle_drivable_apc where players would end up taking marginally more damage when crouching/hiding in the drivers seat because of a mistake with the original implementation

I've updated the comments but the short version is that the APC's m_flViewLowered value operates in the range of [-10, 0] rather than [0, 10], resulting in the player taking 0.75% more damage per hit rather than the (I'm assuming) intended behavior of taking half the value of sk_apc_damage_normal instead (e.g. 7.5% damage instead of 15%)

@Blixibon

Blixibon commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

It turns out that this scale did not implement m_flViewLowered to begin with. I have opened a separate pull request which addresses this. Thank you for bringing it to our attention.

@Blixibon Blixibon closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants