Repository navigation
fix(hle): deliver async open errors on completion - #43
Merged
Merged
Conversation
Verified focused descriptor lifetime and result tests, Windows Release CTest 27/27, stable bootstrap and two baseline-identical replays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserve an fd for an async driver open failure, return the sign-extended error via WaitAsync/PollAsync and release the fd on collection. Preserve immediate path/device errors.
Verified with test_iofilemgr, Windows Release CTest 27/27, bootstrap and two 20M-dispatch traces identical to baseline at 0x08A87150.
Closes #10