Skip to content

Allow unsigned Windows archives for v0.3.1 #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
endercodezz merged 1 commit into from
Nov 4, 2026
+15 −2
Merged

Allow unsigned Windows archives for v0.3.1 #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,8 @@ jobs:
sign-windows:
name: Sign Windows binaries
# Release signing only; PRs never touch keys. Secrets live only in CI, never in the repo (see docs/CODE-SIGNING.md).
if: github.server_url == 'https://github.com' && (startsWith(github.ref, 'refs/tags/v') || github.event_name == 'workflow_dispatch')
# One-time exception while Azure Artifact Signing is unavailable.
if: github.server_url == 'https://github.com' && github.ref != 'refs/tags/v0.3.1' && (startsWith(github.ref, 'refs/tags/v') || github.event_name == 'workflow_dispatch')
needs: desktop
runs-on: windows-latest
permissions:
Expand Down Expand Up @@ -454,7 +455,15 @@ jobs:
package:
name: Verify release archives
# Manual runs rehearse release packaging without creating a tag or draft release.
if: github.server_url == 'https://github.com' && (startsWith(github.ref, 'refs/tags/v') || github.event_name == 'workflow_dispatch')
if: >-
!cancelled()
&& github.server_url == 'https://github.com'
&& (startsWith(github.ref, 'refs/tags/v') || github.event_name == 'workflow_dispatch')
&& needs.desktop.result == 'success'
&& needs.windows-parity.result == 'success'
&& needs.macos.result == 'success'
&& (needs.sign-windows.result == 'success'
|| (github.ref == 'refs/tags/v0.3.1' && needs.sign-windows.result == 'skipped'))
needs: [desktop, windows-parity, sign-windows, macos]
runs-on: ubuntu-latest
steps:
Expand Down
3 changes: 3 additions & 0 deletions docs/CODE-SIGNING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ Windows показывает BYDLO как приложение «неизвес

## Проверка релиза

Выпуск `v0.3.1` — разовое исключение: BYDLO и его помощник в Windows-архивах
поставляются без подписи. CI проверяет комплектность архивов и их SHA-256.

Обязательный шаг релиза (job `sign-windows` в `.github/workflows/ci.yml`):

1. `Azure/trusted-signing-action` подписывает оба `BYDLO.exe` и оба `helper/Bydlo.Helper.exe`;
Expand Down
1 change: 1 addition & 0 deletions docs/RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Исправлена подготовка Zapret на macOS, локализованы сообщения об ошибках.
- На Windows добавлено повышение прав при запуске по выбору пользователя. Усилена защита файлов с секретами.

Windows-сборки BYDLO в этом выпуске не подписаны. Контрольные суммы архивов доступны в `SHA256SUMS.txt`.

# BYDLO v0.3.0

Expand Down
Loading