Don't attempt to pair up empty/unknown symbols with matching names - #412
Open
LagoLunatic wants to merge 1 commit into
Open
LagoLunatic wants to merge 1 commit into
LagoLunatic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
objdiff already skips over undiffable symbols like empty symbols and unknown section types without trying to pair them up when they're on the left side, but it didn't do this when they're on the right. This resulted in symbols being paired strangely in rare cases where a diffable left symbol had the same name as an undiffable right symbol (e.g. because of bad symbols.txt). Now both left and right skip over undiffable symbols when pairing.
This bug fix has the side effect of improving diffing performance, because objdiff now doesn't waste time on symbols that won't be showed anywhere anyway, such as
.lineor.dwarfsymbols. For TP debug, this more than doubles report generation speed.