Improve MWCC class unique ID normalization; normalize on the demangled name - #411
Open
LagoLunatic wants to merge 3 commits into
Open
LagoLunatic wants to merge 3 commits into
LagoLunatic wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues with MWCC class unique ID normalization for symbol pairing:
$132966and$55068would not have been recognized as the same)The third issue is difficult to fix on the mangled name, as the length of the name is included within the symbol, so I switched it to normalize and compare on the demangled version of the name, which does not include these lengths. This is inconsistent with how the mangled name is usually used for comparisons in all other cases in objdiff. However, it's a simpler solution that trying to fix the mangled name lengths, as that requires duplicating a large chunk of demangler logic within objdiff (#410).
Only downside I'm aware of here is that if the demangler ever failed to work on one of these symbols for some reason, the normalization would also not happen either then.