setup, discover --save: save the LAN address or usb, not the USB link

[wardviaene]

Problem

Found on 2026-10-15 while onboarding benchpod-baea06 (firmware 3.9.0, on USB and on the LAN at 192.168.1.220) with benchpod setup from v0.7.0:

• Step 1 reported only network 10.237.8.85:8080: mDNS hears the pod on every interface, and preferredPodIP picks the USB network link address.
• Step 5 saved 10.237.8.85:8080 as the default connection, and the next steps printed pytest --benchpod-connection=10.237.8.85.

That address only works while the pod is plugged into this computer. A tester who sets up at a desk and then moves the pod to Ethernet in a lab gets a broken default. discover --save already mapped a USB-link address to usb, but it also ignored the LAN address when the pod had one.

Rule

The saved default connection (savedConnection) is:

1. the pod's Ethernet or Wi-Fi address when it has one (from mDNS on a non-USB interface, or from the console's status);
2. else usb for a pod reached only on its USB link (10.237.0.0/16), which re-detects on any port and falls back to the console when Wi-Fi turns USB networking off;
3. else the address as it is.

A --connection passed to setup is saved as given (usb:<name> is kept instead of plain usb). Setup still drives the pod over the USB link during the run; only the saved value and the pytest hint change.

Changes

• discoveredPod.lanAddr: the first non-USB-link IPv4 that mDNS returned. discover shows it in the health line (LAN address 192.168.1.220:8080).
• saveTarget (discover --save) and setup step 5 both use savedConnection.
• Setup step 1 says USB network 10.237.8.85:8080, network 192.168.1.220:8080. Step 2 no longer calls the USB link "on the network": a USB-only pod is fine for this computer, and setup says how to add Ethernet or Wi-Fi for other machines and CI. Step 5 explains why it saves usb.
• Help text for setup and discover, plus the README, are updated. The public docs (getting started, CLI page, CLI reference) are updated in embeddedci-server main.

Tests

go test ./cmd/... passes. There are new unit tests for savedConnection, lanPodIP, the LAN-over-link preference in saveTarget, setup saving the LAN address, usb, and explicit connections, and mergeSetupPods keeping the LAN address. These are host-only tests; nothing was run on the bench pod.

internal/fwrefusals fails locally because it reads the sibling firmware checkout, which is on another branch. That failure is unrelated to this change.

🤖 Generated with Claude Code