Repository navigation
Conversation
Volt required vize ~> 0.15.0, so it couldn't be installed alongside vize 0.16, which PhoenixVapor needs. Accept 0.15 or 0.16. vize 0.16 changes only Vize.vapor_split/1, which Volt doesn't call; the functions Volt uses (compile_sfc, parse_sfc, SFC template assets and Vize.CSS) are unchanged. The lock moves to 0.16.0, and the suite passes on it.
Pre-1.0 vize minors may break, so supporting 0.15 as well would mean testing both. Volt follows vize's latest minor, as 0.19.0 did with 0.15.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volt requires
vize ~> 0.15.0, so it can't be installed alongside vize 0.16.0, which was released on October 1. PhoenixVapor needs vize 0.16 and Volt together. This requires~> 0.16.0, moves the lock to 0.16.0, and prepares the 0.19.4 release: the version bump and a dated CHANGELOG section.Why this is safe
vize 0.16's only breaking change is to
Vize.vapor_split/1, which Volt doesn't call. Events andv-modelare now returned as bindings instead ofphx-*attributes; see elixir-volt/vize_ex#6.The vize functions Volt uses keep their public API:
Vize.compile_sfcVize.parse_sfcVize.SFC.collect_template_assetsVize.CSS:compile,compile_sass,select,rewrite_urls,parse_ast,print_ast,postwalkInternally, vize's NIFs now take typed options maps, and SFC block locations gain
tag_start/tag_end.Volt follows vize's latest minor, as 0.19.0 did with 0.15, rather than supporting two pre-1.0 minors.
Verification
MIX_ENV=test mix teston vize 0.16.0, excluding the browser-tagged tests: 728 passed, 5 skipped.mix format --check-formattedandmix compile --warnings-as-errorspass.