Repository navigation
Conversation
Contributor
|
👋 @dobsontom |
dobsontom
requested a deployment
to
elementary_test_env
October 14, 2026 12:40 — with
GitHub Actions
Waiting
dobsontom
requested a deployment
to
elementary_test_env
October 14, 2026 12:45 — with
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses a source's
meta.descriptionas the description in its source freshness alerts, and keeps the existing default where it isn't set. Test alerts already do this (TestAlertDataSchema.format_alerttakesself.description or self.test_description), soSourceFreshnessAlertDataSchemanow does the same.I've added a parametrised test to
tests/unit/monitor/fetchers/alerts/schemas/test_alert_data_schema.pycoveringmeta.description,meta.alerts_config.description, and the fallback. I've also added a source example to the alert description docs.Closes #2396
Summary by CodeRabbit
Bug Fixes
Documentation