Repository navigation
Add --cfn-disable-termination-protection flag to opt out of CloudForm… - #8900
Merged
Merged
Conversation
Contributor
|
Hello DerekFrank 👋 Thank you for opening a Pull Request in |
…ation stack termination protection
DerekFrank
force-pushed
the
karpenter-release
branch
from
October 7, 2026 21:18
c33913e to
0a9bcbe
Compare
gustavodiaz7722
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since #8586, eksctl creates every CloudFormation stack with termination protection enabled, with no way to opt out.
eksctl deleteturns protection off before deleting, which needscloudformation:UpdateTerminationProtection. Callers whose credentials lack that permission can no longer delete the clusters they create. This hits CI systems that create and tear down clusters with tightly scoped IAM roles. #8663 asked for an option to disable this.This adds a
--cfn-disable-termination-protectionflag. It is wired the same way as--cfn-disable-rollback: aProviderConfigfield exposed throughClusterProvider, read byStackCollectionwhen it buildsCreateStackInput. It goes everywhere the other--cfn-*options are registered, socreate cluster,create nodegroup, etc. accept it. The default is unchanged (protection on). Like--cfn-disable-rollback, the flag can't be combined with--dry-run.Closes #8663
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)Manual test
Built from this branch, us-west-2:
EnableTerminationProtectioneksctl create cluster --without-nodegroup --cfn-disable-termination-protectioneksctl-<name>-clusterfalseeksctl create nodegroup --managed(no flag)eksctl-<name>-nodegroup-ng-defaulttrueeksctl delete cluster --waitthen removed both stacks (one protected, one not) and the cluster.