Skip to content

Stop using setGitDate and rely on buildtime for qualifiers - #477

Merged
jonahgraham merged 1 commit into
eclipse-packaging:masterfrom
jonahgraham:remove-setGitDate
Oct 15, 2026
Merged

jonahgraham merged 1 commit into
eclipse-packaging:masterfrom
jonahgraham:remove-setGitDate

Conversation

@jonahgraham

Copy link
Copy Markdown
Contributor

Fixes #169

@jonahgraham
jonahgraham requested a review from merks October 15, 2026 16:59
@jonahgraham

Copy link
Copy Markdown
Contributor Author

@merks this seemed to do what I expect, i.e. qualifiers that match build time, e.g.:

packages/org.eclipse.epp.package.cpp.product/target/repository/features/org.eclipse.epp.package.common.feature_4.42.0.20261015-1636.jar

@jonahgraham

Copy link
Copy Markdown
Contributor Author

Verified too on GitHub CI here

[INFO] The project's OSGi version is 4.42.0.20261015-1659

@merks merks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s do it. Please merge.

@jonahgraham
jonahgraham merged commit 6bb58b2 into eclipse-packaging:master Oct 15, 2026
11 checks passed
@jonahgraham
jonahgraham deleted the remove-setGitDate branch October 15, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review/revisit for qualifier updates

2 participants