Skip to content

refactor: modernize JS to pass ESLint #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjroelofs merged 1 commit into from
Aug 6, 2026
Merged

refactor: modernize JS to pass ESLint #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 36 additions & 39 deletions js/rl-sorting-tracking.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,27 +2,24 @@
'use strict';

Drupal.behaviors.rlSortingTracking = {
attach: function (context, settings) {
attach(context, settings) {
if (!settings.rlSorting || !settings.rlSorting.views) {
return;
}

once('rl-sorting-tracking', '.view', context).forEach(function(view) {
var viewIdClass = Array.from(view.classList).find(cls => cls.startsWith('view-id-'));
var displayIdClass = Array.from(view.classList).find(cls => cls.startsWith('view-display-id-'));
var viewId = viewIdClass ? viewIdClass.replace('view-id-', '') : 'unknown';
var displayId = displayIdClass ? displayIdClass.replace('view-display-id-', '') : 'unknown';
var viewDisplayKey = viewId + '.' + displayId;
once('rl-sorting-tracking', '.view', context).forEach((view) => {
const viewIdClass = Array.from(view.classList).find(cls => cls.startsWith('view-id-'));
const displayIdClass = Array.from(view.classList).find(cls => cls.startsWith('view-display-id-'));
const viewId = viewIdClass ? viewIdClass.replace('view-id-', '') : 'unknown';
const displayId = displayIdClass ? displayIdClass.replace('view-display-id-', '') : 'unknown';
const viewDisplayKey = `${viewId}.${displayId}`;

if (!settings.rlSorting.views[viewDisplayKey]) {
return;
}

var viewSettings = settings.rlSorting.views[viewDisplayKey];
var experimentId = viewSettings.experimentId;
var entityIds = viewSettings.entityIds;
var entityUrlMap = viewSettings.entityUrlMap;
var rlEndpointUrl = viewSettings.rlEndpointUrl;
const { experimentId, entityUrlMap, rlEndpointUrl }
= settings.rlSorting.views[viewDisplayKey];

// Fail hard if required data is missing
if (!experimentId || !rlEndpointUrl) {
Expand All @@ -31,56 +28,56 @@

// Track rewards (when links are clicked) and turns (when links become visible)
if (entityUrlMap && Object.keys(entityUrlMap).length > 0) {
var links = view.querySelectorAll('a');
var visibleArms = [];
var batchTimer = null;
// Function to send batched turns
function sendBatchedTurns() {
const links = view.querySelectorAll('a');
let visibleArms = [];
let batchTimer = null;

// Send batched turn impressions to the RL endpoint
const sendBatchedTurns = () => {
if (visibleArms.length > 0) {
var formData = new FormData();
const formData = new FormData();
formData.append('action', 'turns');
formData.append('experiment_id', experimentId);
formData.append('arm_ids', visibleArms.join(','));

navigator.sendBeacon(rlEndpointUrl, formData);
visibleArms = [];
}
}
};

// Create a single observer for all links in this view
var turnObserver = new IntersectionObserver(function(entries) {
entries.forEach(function(entry) {
const turnObserver = new IntersectionObserver((entries) => {
entries.forEach((entry) => {
if (entry.isIntersecting) {
var entityId = entry.target.dataset.entityId;
const entityId = entry.target.dataset.entityId;
if (entityId && !entry.target.dataset.tracked) {
visibleArms.push(entityId);
entry.target.dataset.tracked = 'true';
turnObserver.unobserve(entry.target);

// Clear existing timer and set new one
clearTimeout(batchTimer);
batchTimer = setTimeout(sendBatchedTurns, 100);
}
}
});
}, {threshold: 0.1});

links.forEach(function(link) {
var href = link.getAttribute('href');
var entityId = Object.keys(entityUrlMap).find(id => entityUrlMap[id] === href);

}, { threshold: 0.1 });

// Session storage key for tracking rewarded experiments in this page load
const storageKey = `rl_sorting_rewarded_${experimentId}`;

links.forEach((link) => {
const href = link.getAttribute('href');
const entityId = Object.keys(entityUrlMap).find(id => entityUrlMap[id] === href);

if (entityId) {
link.dataset.entityId = entityId;

// Observe for visibility tracking
turnObserver.observe(link);

// Session storage key for tracking rewarded experiments in this page load.
var storageKey = 'rl_sorting_rewarded_' + experimentId;

// Track reward when clicked
link.addEventListener('click', function() {
link.addEventListener('click', () => {
// Check if we've already sent a reward for this experiment in this page load.
if (sessionStorage.getItem(storageKey)) {
// Already rewarded this turn, skip.
Expand All @@ -91,7 +88,7 @@
sessionStorage.setItem(storageKey, '1');

// Create FormData for POST request to rl.php
var formData = new FormData();
const formData = new FormData();
formData.append('action', 'reward');
formData.append('experiment_id', experimentId);
formData.append('arm_id', entityId);
Expand All @@ -103,6 +100,6 @@
});
}
});
}
},
};
})(Drupal, once);
})(Drupal, once);
Loading