Repository navigation
feat: add ESLint with @antfu/eslint-config and CI workflow - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@antfu/eslint-configflat config for modern JavaScript linting.Drupal,drupalSettings,once,jQuery, etc.) so module JS files lint cleanly against browser and Drupal APIs.changesdetection job (viadorny/paths-filter) and aneslintjob that only runs when JS files change, keeping CI fast for PHP-only PRs.Closes #2
Test plan
npm ci && npx eslint .runs locally and reports errors (no crashes).eslintjob triggers on a PR that touches JS files.eslintjob is skipped on a PR that only touches PHP/YAML files.drupal-lintanddrupal-checkCI jobs still run as before.