Repository navigation
Improve RL reports with bulk deletion and sortable columns - #74
Merged
Merged
Conversation
Contributor
Author
|
Reviewed the routing, services, No correctness issues found:
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73.
/admin/reports/rlnow supports selecting experiments and deleting them together after a confirmation page lists their names and IDs. The overview uses Drupal's standard checkbox table and action controls, shows 50 rows per page, and checks the existing administration permission again on submission. Selected experiments remain selected if live statistics move them to another page before submission. Private temporary storage keeps each user's selections separate, with independent tokens for separate tabs. Single and bulk deletion share the same transactional cleanup of registry entries, arm data, totals, and snapshots. Adestinationparameter is deferred until after confirmation.All seven data headings now sort in both directions using Drupal's
TableSort, with numeric counts, timestamps, displayed-name/activity fallbacks, and stable ties. Sorting precedes pagination. Experiment names link to their reports, and individual Delete actions sit beneath the names so every column heading represents sortable data. Core responsive-column priorities expose a Show all columns control on narrow screens. Confirmation and cancellation preserve the sort and page.Drupal 11 core references
tableselect, bulk action selector, private tempstore, and confirmation redirect.ConfirmFormBasebecause its experiment registry is stored in custom tables rather than entities.aria-sort.Validation
0or brackets (including accessible checkbox labels). Also checked live statistics reordering between display and submission, destination handling, revoked permissions, and independent selections in separate tabs. The validation code is kept outside this PR.git diff --checkpasses.rl_requirements()andCacheResponseSubscriber::getSubscribedEvents(); there are no failing assertions.3b0fbe4passed Drupal lint and E2E tests. Its compatibility check against Drupal 11.5 development core reports four existingdrupal_static()deprecations in unchanged code. Those are addressed separately in Replace deprecated static storage for Drupal 11.5 compatibility #75; merge that fix and update this branch to clear the compatibility failure.