Repository navigation
Disable APT download retries before every networked APT path - #1128
Merged
Merged
Conversation
durable-workflow/.github#295 (CVE-2026-109518): vulnerable APT can follow a redirect on a retried package download. Write Acquire::Retries "0" before the first APT-capable step of each job that runs shivammathur/setup-php (php.yml x5, dependency-security.yml, release-verification.yml) and before apt-get in the tracing-performance and embedded-http runtime Dockerfiles. scripts/ci/test-apt-no-retries.py (copied from sdk-php#399, extended to Dockerfiles per build stage) fails when a job or stage runs networked APT without the line first; it runs in php.yml's routing job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Member
Author
|
Security PASS at e122736 (.github#295). Guards precede setup-php in the five php.yml jobs, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow repo slice of durable-workflow/.github#295 (CVE-2026-109518), the paths General listed.
Acquire::Retries "0"is written to/etc/apt/apt.conf.d/99-no-retriesbefore the first apt-capable step in each job. That's php.yml ×5 jobs,dependency-security.ymlandrelease-verification.yml.apt-getin.github/tracing-performance/Dockerfile(unpinnedphp:8.3.35-cli-bookworm) andexamples/embedded-http/runtime/Dockerfile(old bookworm parent).scripts/ci/test-apt-no-retries.py, copied from sdk-php#399, is extended to check every Dockerfile build stage. It fails if any job or stage reaches networked APT before the line, and its self-tests cover late, missing,--with-depsand per-stage cases. It runs in php.yml's routing job.Locally the new test passes, along with the public-boundary check.
test-build-routing.pycan't run here because it needsphpin temp directories, so CI covers it.🤖 Generated with Claude Code