Populate the HTTPException body - #614
Open
afeld wants to merge 3 commits into
Open
Conversation
Co-authored-by: afeld <86842+afeld@users.noreply.github.com>
Co-authored-by: afeld <86842+afeld@users.noreply.github.com>
Co-authored-by: afeld <86842+afeld@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to debug 404s and wasn't able to see the HTTP response body — it's always an empty string. I found the relevant code, then had Copilot make the fix. I tried running the test locally, but couldn't figure out how to build with httpfs. Hoping that CI shows it working. I haven't done C++ in 20 years, so open to any suggestions.
Here's Copilot's explanation of the change:
HTTPException.bodycould remain empty because Python exception mapping only readresponse_bodyfrom DuckDB error extra-info. Some HTTP errors now surface payload underbody, so the attribute was silently unset.Exception field mapping
response_bodybodyHTTPException.bodyfor newer payloads.Test expectation alignment
bodyas a string instead of assuming it is always empty.