CI: drop obsolete Homebrew lame / pkg-config steps - #4
Merged
Merged
Conversation
libmp3lame has been vendored as Frameworks/Mp3Lame.xcframework (a SwiftPM binary target) since de1e033, so the workflow no longer needs Homebrew's lame. Those leftover steps broke every run once Homebrew's lame 4.0 bottle stopped shipping mp3lame.pc (pkg-config --libs mp3lame: not found). Also correct the README's Building section, which still said lame came from the dropped PipelineHelpers dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Build workflow has failed on every run since 2026-08-26 (for example run 35813139664). The failing step is
pkg-config --libs mp3lame: Homebrew'slame4.0 bottle no longer shipsmp3lame.pc.Those steps are leftovers. Since de1e033, libmp3lame has been vendored as
Frameworks/Mp3Lame.xcframework, a SwiftPM binary target, so the build never used Homebrew's lame. This PR removes thebrew install lame pkg-configand pkg-config check steps.It also corrects the README's Building section, which still said lame came from the dropped PipelineHelpers dependency.
🤖 Generated with Claude Code