Repository navigation
fix: bare init ensures the local HC holder - #333
Merged
Merged
Conversation
A designated installation's bare init starts or repairs the pinned HC core and holder without claiming the coordinator.
70 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A bare
initin the designated installation now makes sure the pinned local HC core has a current holder.It still returns the developer role and does not claim the coordinator.
The core was up with no holder, so
coordinator startfailed before it created a terminal.hc server startdid not repair that, and a restart alone did not create the holder until a program ran.The ensure path starts a stopped core.
It restarts a holderless core only when nothing is live.
If the holder is still missing, it runs
true, removes that terminal, and checks again.An explicit developer init, a development checkout, a missing pinned
hc, and a holderless core with live terminals do not start or restart anything.Validation
mise run verifywas not executed, and there is no.artifacts/verification/record.MISE_ENABLE_TOOLS=go mise exec -- go test ./internal/hcboot ./internal/cli -count=1 -timeout 180s -run 'TestEnsure|TestBareInitEnsures|TestInitUnboundDesignated|TestInitExplicitAuthority'passed in the dev checkout.initwas run against the real HC core for this change..local/bin/sumctl, so this behavior starts only after that helper is rebuilt from the merged tree.Human review and the branch-protection owner decide merge readiness.