Repository navigation
Allow overriding the API token with DEV_PROXY_API_TOKEN #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
27c6fac
Allow overriding the API token with DEV_PROXY_API_TOKEN
waldekmastykarz ee5bdb2
Validate DEV_PROXY_API_TOKEN at proxy start after env overrides
waldekmastykarz 43fd70e
Gate detached token preflight on help/version only
waldekmastykarz 99aa5af
Exclude = padding from API token minimum and drop detached preflight
waldekmastykarz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using Xunit; | ||
|
|
||
| namespace DevProxy.Tests; | ||
|
|
||
| public class ApiSecurityTokenTests | ||
| { | ||
| [Theory] | ||
| [InlineData(null)] | ||
| [InlineData("")] | ||
| [InlineData(" ")] | ||
| public void TryResolveToken_NoOverride_GeneratesRandomToken(string? value) | ||
| { | ||
| Assert.True(ApiSecurity.TryResolveToken(value, out var first, out var error)); | ||
| Assert.Null(error); | ||
| Assert.Equal(64, first.Length); | ||
| Assert.True(first.All(Uri.IsHexDigit)); | ||
|
|
||
| Assert.True(ApiSecurity.TryResolveToken(value, out var second, out _)); | ||
| Assert.NotEqual(first, second); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryResolveToken_ValidOverride_UsesValue() | ||
| { | ||
| var value = Convert.ToHexString(System.Security.Cryptography.RandomNumberGenerator.GetBytes(32)); | ||
|
|
||
| Assert.True(ApiSecurity.TryResolveToken(value, out var token, out var error)); | ||
| Assert.Null(error); | ||
| Assert.Equal(value, token); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryResolveToken_OverrideWithSurroundingWhitespace_IsTrimmed() | ||
| { | ||
| var value = new string('a', 32); | ||
|
|
||
| Assert.True(ApiSecurity.TryResolveToken($" {value}\n", out var token, out _)); | ||
| Assert.Equal(value, token); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData("abcdefghijklmnopqrstuvwxyz-._~+/0123==")] | ||
| [InlineData("ABCDEFGHIJKLMNOPQRSTUVWXYZ012345")] | ||
| public void TryResolveToken_Base64TokenCharacters_Accepted(string value) | ||
| { | ||
| Assert.True(ApiSecurity.TryResolveToken(value, out var token, out _)); | ||
| Assert.Equal(value, token); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData("short")] | ||
| [InlineData("0123456789abcdef0123456789abcde")] | ||
| public void TryResolveToken_TooShort_Fails(string value) | ||
| { | ||
| Assert.False(ApiSecurity.TryResolveToken(value, out _, out var error)); | ||
| Assert.Contains(ApiSecurity.TokenEnvironmentVariable, error, StringComparison.Ordinal); | ||
| Assert.Contains("32", error, StringComparison.Ordinal); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData("0123456789abcdef 0123456789abcdef")] | ||
| [InlineData("0123456789abcdef0123456789abcdef\u00e9")] | ||
| [InlineData("0123456789abcdef0123456789abcdef;")] | ||
| [InlineData("0123456789abcdef=0123456789abcdef")] | ||
| public void TryResolveToken_InvalidCharacters_Fails(string value) | ||
| { | ||
| Assert.False(ApiSecurity.TryResolveToken(value, out _, out var error)); | ||
| Assert.Contains(ApiSecurity.TokenEnvironmentVariable, error, StringComparison.Ordinal); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData("================================")] | ||
| [InlineData("a===============================")] | ||
| public void TryResolveToken_PaddingNotCountedTowardMinimum_Fails(string value) | ||
| { | ||
| Assert.False(ApiSecurity.TryResolveToken(value, out _, out var error)); | ||
| Assert.Contains("padding", error, StringComparison.Ordinal); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void TryResolveToken_MinimumLengthWithPadding_Accepted() | ||
| { | ||
| var value = new string('a', 32) + "=="; | ||
|
|
||
| Assert.True(ApiSecurity.TryResolveToken(value, out var token, out _)); | ||
| Assert.Equal(value, token); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.