Correct handler class name and route name separator in routing page - #26
Merged
Merged
Conversation
Signed-off-by: arhimede <julian@dotkernel.com>
bidi47
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The routing page documented a class that no longer exists and a route name that throws when used.
PageHandlerwas renamed toGetPageViewHandlerin release 1.2.0, but both the prose and the code sample still used the old name.$moduleNameand wrapped the handler in an array; the currentsrc/Page/src/RoutesDelegator.phpiterates$prefixand passes the handler unwrapped. The sample now matches the source verbatim.page.about. The separator is::, sourl('page.about')throws —request-lifecycle.mdalready had it right and the two pages contradicted each other.Pagedoes.Appregisters a single static/route, which is now shown.