Repository navigation
fix misplaced links in community notes - #1428
Merged
Merged
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The note text was escaped before being split into characters, so every
",',&,<or>became an entity several characters long and pushed thefromIndex/toIndexlink positions out of place (in the #1259 note the two quotes around "Made with AI" shift both links 10 characters to the left). Escaping each character after splitting keeps the indices lined up; the same block is fixed in helpers.js and tweetviewer.js. I couldn't test it against a live account, so I ran the note rendering block in node with the text from the screenshot, which gives the exact broken output before this change and the right links after.Fixes #1259