Skip to content

'How it was built' gives the wrong reason when the schema check fails to run #36

Open

Description

@threeqube

What

When the Open Badges schema check can't run, the "How it was built" row reads "couldn't load the standard to check it against" (listChecks in src/outcomes.ts). Since verifier-core 2.0.0-beta.1 the schemas are bundled with the library and nothing is loaded, so the only way to reach this is the validator itself failing. The words give a reason that can't be the real one.

Rare, and it was so on main before #31. Found in the final review of #31.

Proposed fix

Neutral words that don't name a cause, in line with the wording rule (a "couldn't check" never accuses and never leans positive), e.g. "couldn't check it against the standard". Earner-facing, so the proposed wording will go to James on the PR before it merges, as usual. Could go in the same PR as the registry-name change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions