Repository navigation
Conversation
Render native plan artifacts in exported HTML and reject plan lifecycle state from print-mode activation paths. Cover tree export, queued prompts, and JSON event suppression without exposing plan bookkeeping.
Keep native plan lifecycle state out of JSON and RPC wire protocols while rejecting non-interactive plan targets before mutation. Cover startup, replacement, prompt, and streaming command boundaries.
- Print, JSON, and RPC consumers could not observe or resolve a plan, which made plan mode unusable outside the TUI - Profile switch notices and the RpcEvent union stay in the integration stack so these modes carry no task profile dependency
Issacboy123
approved these changes
Aug 17, 2026
Issacboy123
left a comment
Issacboy123
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Native plan artifacts now flow through print, JSON events, RPC, and HTML export instead of being translated into mode-specific substitutes. Focused tests cover each surface. No issues discovered during my review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes plan mode observable and resolvable outside the TUI, across print, JSON, and RPC output modes, and in exported HTML transcripts.
Replaces #71.
Reasoning
Plan mode was only reachable interactively, which made it unusable for scripted and RPC callers.
Plan lifecycle events are deliberately suppressed on the RPC wire rather than forwarded, because RPC clients resolve plans through explicit commands and would otherwise see state transitions they cannot act on.
Profile switch notices and the
RpcEventunion stay in the integration stack, so these modes carry no task profile dependency.Changes
Testing
npx vitest --run test/print-mode.test.ts test/rpc-prompt-response-semantics.test.ts test/export-html-plan-mode.test.tstsgo --noEmitreports zero errors