Repository navigation
Conversation
Exercise replacement reservations, concurrent transitions, and disposal ordering across runtime operations.
Exercise accepted plan routing, profile metadata, and built-in tool suppression across harness activation.
- Concurrent prompt admission during a plan rebind could reorder queued work, and no test pinned the ordering - Session profile metadata assertions are held for the integration stack because that field does not exist on main
- The new plan mode case asserted that leaving plan mode restores only the extension tool, contradicting the assertion thirty lines above it for the same session configuration - Restoring the full default set is the established behaviour, so the expectation is aligned with its sibling rather than the implementation being changed
Issacboy123
approved these changes
Aug 17, 2026
Issacboy123
left a comment
Contributor
There was a problem hiding this comment.
LGTM! These tests cover exclusive runtime transitions, routing races, and tool restoration when built-ins are disabled. They also treat accepted-plan routing as distinct from an ordinary prompt. I found no issues during review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds runtime coverage for prompt admission races around plan continuations, and corrects a plan mode tool expectation that contradicted its own sibling assertion.
Replaces #67.
Reasoning
Prompt admission and session replacement can interleave, and ordering bugs there are easy to introduce and hard to notice.
These tests pin the ordering rather than the implementation, so the coordinator can be refactored without rewriting them.
The plan mode case in the
#3592regression file asserted that leaving plan mode restores only the extension tool, while the assertion thirty lines above it expects the full default set for the same session configuration.Restoring the full set is the established behaviour, so the expectation was aligned with its sibling rather than the implementation being changed.
Session profile metadata assertions from the original PR are held for the integration stack.
Changes
#3592regression testTesting
npx vitest --run test/suite/agent-session-runtime.test.ts test/suite/regressions/3592-no-builtin-tools-keeps-extension-tools.test.tstsgo --noEmitreports zero errors