Repository navigation
Conversation
Exercise plan submission, collaboration guards, and extension command ownership at the session boundary.
Verify queued prompts preserve ordering and plan submissions remain exclusive across preflight races.
Verify accepted and resumed plans persist exact continuation state across session lifecycle transitions.
Issacboy123
approved these changes
Aug 17, 2026
Issacboy123
left a comment
Issacboy123
left a comment
Contributor
There was a problem hiding this comment.
LGTM! This is focused harness coverage for tool policy, queued prompts, durable continuations, and accepted-plan implementation. It exercises the new session boundaries without a live provider. No issues discovered during review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression coverage for the plan session contract: queued work while a plan is pending, and continuations that survive a session rebind.
Replaces #66.
Reasoning
The durable part of plan mode is the part most likely to regress silently.
An accepted plan can outlive the session object that produced it, so the tests exercise resolution, persistence, and rebind together rather than asserting on in-memory state alone.
Profile routing assertions from the original PR are held for the integration stack, since they need modules that do not exist on
main.Changes
test/suite/agent-session-plan-mode.test.tscovering mode transitions, tool swapping, and guard rejectionsTesting
npx vitest --run test/suite/agent-session-plan-mode.test.tstsgo --noEmitreports zero errors