Skip to content

fix(coding-agent): simplify provider login menu #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pepps233 merged 4 commits into from
Oct 27, 2026
Merged

fix(coding-agent): simplify provider login menu #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
967aff7
fix(coding-agent): remove Diffex login option
Pepps233 Oct 27, 2026
367120d
fix(ai): synchronize callback validation
Pepps233 Oct 27, 2026
0b14f58
fix(coding-agent): select account login in smoke
Pepps233 Oct 27, 2026
b6f88af
fix(coding-agent): synchronize secure fixtures
Pepps233 Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions packages/coding-agent/src/modes/interactive/interactive-mode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,6 @@ type LoginProviderCompletionOption = {
const AUTH_TYPE_ORDER = { oauth: 0, api_key: 1 } satisfies Record<AuthSelectorProvider["authType"], number>;
const DIFFEX_ACCOUNT_LOGIN_ID = "diffex";
const DIFFEX_ACCOUNT_SELECTOR_ID = "diffex-account";
const DIFFEX_ACCOUNT_LOGIN_LABEL = "Sign in to Diffex";

function createFuzzyAutocompleteItems<T>(
items: T[],
Expand Down Expand Up @@ -6238,7 +6237,7 @@ export class InteractiveMode {
const availableAuthTypes = providerOptions
? new Set(providerOptions.map((provider) => provider.authType))
: new Set<AuthSelectorProvider["authType"]>(["oauth", "api_key"]);
const options: string[] = providerOptions ? [] : [DIFFEX_ACCOUNT_LOGIN_LABEL];
const options: string[] = [];
if (availableAuthTypes.has("oauth")) {
options.push(subscriptionLabel);
}
Expand Down Expand Up @@ -6268,10 +6267,6 @@ export class InteractiveMode {
options,
(option) => {
done();
if (option === DIFFEX_ACCOUNT_LOGIN_LABEL) {
void this.showDiffexAccountLoginDialog();
return;
}
const authType = option === subscriptionLabel ? "oauth" : "api_key";
if (providerOptions) {
const providerOption = providerOptions.find((provider) => provider.authType === authType);
Expand Down
2 changes: 1 addition & 1 deletion scripts/verify-candidate-artifacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
os.write(fd, b"/login\r")
stage = "login"
elif stage == "login" and "Select authentication method:" in text:
os.write(fd, b"\x1b[B\r")
os.write(fd, b"\r")
stage = "accounts"
elif stage == "accounts" and all(
name in text for name in ["OpenAI Codex", "Radius", "xAI"]
Expand Down
Loading