Repository navigation
fix(ai): complete Diffex provider branding - #288
Merged
Merged
Conversation
- Direct users back to the terminal for final sign-in status - Keep callback validation and timing while hiding provider error details
- Identify default provider traffic as Diffex without changing authentication or inference protocols - Preserve configured headers, optional attribution controls, and session behavior
- Record offline evidence and the intentional identity exceptions - Keep live provider compatibility checks explicit before release
- Use the official Diffex mark and entrance boat for consistent branding - Keep browser return instructions concise
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Match only the exact inline SVG namespace so unrelated hosts cannot pass callback resource checks
- Create private temporary directories atomically for SDK tests
Contributor
Author
|
Addressed the callback resource assertion by exempting only the exact SVG namespace. Validation: callback and attribution tests, This comment is AI-generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use consistent Diffex branding on OAuth callback pages and default provider request attribution.
Reasoning
Users should see accurate application identity and sign-in status throughout the Diffex migration.
Provider-specific protocols and explicit header overrides remain respected.
Changes
Testing
npm run checkand./test.shpassed on the complete local revision.