Repository navigation
fix(evolution): preserve failed evidence for retry - #258
Open
Issacboy123 wants to merge 3 commits into
Open
Issacboy123 wants to merge 3 commits into
Issacboy123 wants to merge 3 commits into
Conversation
Pepps233
requested changes
Oct 8, 2026
Pepps233
left a comment
Contributor
There was a problem hiding this comment.
Add a maximum retry amount / retry counter per unreadable / broken trace. Currently, if a trace is broken due to permission issues such as file permissions, it will retry forever. Maybe add a maximum retry amount of 2?
Pepps233
approved these changes
Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evolution could silently skip unreadable trace evidence by advancing its processed cursor past a failed materialization. This change stops processing at the first failure, keeps that trace eligible for retry, and exposes a generic retry notice while still allowing a valid earlier prefix to be processed.
This PR is stacked on the Together model-ID correction.
Reasoning
Representing the first materialization failure at the evidence-catalog boundary gives the control plane a precise contiguous range to commit. This prevents manual and automatic jobs from consuming later evidence out of order. Successful materializations remain reusable while pending, then are discarded after their cursor is committed, avoiding indefinite retention without caching failures.
Changes
Testing
node ../../node_modules/vitest/dist/cli.js --run test/evolution-runtime.test.ts test/evolution-menu.test.tsnode ../../node_modules/vitest/dist/cli.js --run test/invocation-tracing.test.tsnode ../../node_modules/vitest/dist/cli.js --run test/control-plane.test.ts test/control-service.test.tsnpm run check