Repository navigation
Conversation
Pepps233
self-requested a review
October 4, 2026 18:02
Pepps233
added this pull request to stack #256
October 4, 2026 18:34
Use fixed provider inputs in isolated copies of the real model generator so Together catalog removals cannot invalidate metadata regression tests, while retaining strict failure and compatibility coverage. Run the existing CI workflow for pull requests against prerequisite branches so every stacked head receives the full build and test checks.
Prevent real npm integrity checks from failing on idle pooled sockets by explicitly closing and framing owned registry responses. Start bounded cancellation escalation only after the real archive request, retain a finite startup deadline, record observed child completion, and clean up the detached fixture group while preserving strict checksum, installation, and repair assertions.
Pepps233
force-pushed
the
codex/token-pr-companion-00-catalog-fixtures
branch
from
October 4, 2026 18:35
a1f2755 to
18e8620
Compare
Pepps233
approved these changes
Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review size: 457 meaningful changed lines, plus 0 generated lines and 0 documentation lines, counted as additions plus deletions.
Base:
mainat 6a4091d; head:codex/token-pr-companion-00-catalog-fixtures.Fixes the typecheck and runtime failures caused by tests assuming
deepseek-ai/DeepSeek-V4-Proalways remains in Together's live catalog.Runs the full existing CI workflow for every pull request, including requests based on prerequisite branches.
Fixes native acceptance fixtures reporting
ECONNRESETinstead of checksum failure, or cancelling an update before npm reaches the real archive download.Reasoning
Model availability changes outside the repository, so generator behavior is tested using fixed provider responses while normal builds continue to refresh public catalogs.
The fixtures run the real strict generator in temporary copies, preserving every existing Together metadata, reasoning-control, and compatibility assertion and verifying that absent, deprecated, or tool-incompatible models stay excluded.
This small prerequisite isolates catalog determinism from the dependency security changes in the following PR.
Removing the pull-request base-branch filter verifies each stacked head with the existing build and test shards, retaining all jobs and permissions.
The owned registry fixture closes each connection and declares response sizes to avoid pooled-socket races.
Cancellation has separate bounded startup and shutdown deadlines, observes the real archive request before signalling, and always cleans up the owned process group.
The integrity, installation-preservation, pinned-repair, and archive-download assertions remain strict.
Changes
mainbase-branch filter from the CI pull-request trigger.Testing
npm run buildusing captured public catalog responses with Together's DeepSeek-V4-Pro omitted.npm ci --ignore-scriptsusing this PR's exact main-branch lockfile.npm run build, with a Node preload supplying the captured catalog responses after the fix.npm run check, including after catalog regeneration.packages/ai:node ../../node_modules/vitest/dist/cli.js --run test/together-models.test.ts test/generate-models-strict.test.ts: 7 tests passed../test.sh, using the repository's isolated test runner.node scripts/npm-lifecycle.mjs REVIEWED_TARBALL EVIDENCE_DIRECTORYpassed full npm/Bun lifecycle checks on Linux ARM64 with Node 22.19.0, npm 11.16.0, and Bun 1.3.11 under the controlled stalls, including observed SIGTERM at the archive boundary, strict integrity rejection, prefix preservation, pinned repair, retained data, and cleanup.The hosted workflow separately rebuilds the current pull-request artifact.