Repository navigation
Conversation
Pepps233
self-requested a review
October 4, 2026 18:02
Pepps233
added this pull request to stack #256
October 4, 2026 18:34
Require hosted gateway credentials and the server output cap at startup, then remove the credential from the process environment. Verify the real SDK, WebSocket and restart paths through local acceptance fixtures, preserve required distribution inputs, and inspect compressed image layers without hiding prohibited earlier-layer files.
Pepps233
force-pushed
the
codex/token-pr-companion-03-metered-runtime
branch
from
October 4, 2026 18:35
1777e29 to
8efb254
Compare
Pepps233
requested changes
Oct 4, 2026
Pepps233
left a comment
Contributor
There was a problem hiding this comment.
not appropriate to merge yet. do not force cloud runtime to supply diffex credentials yet. this changes production runtime behavior and should be discussed with the team before modifications. please hold back on merging this pr stack.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requires the hosted server to use gateway credentials and validates the real WebSocket-to-model path, restart behavior, and runtime image inspection.
Reasoning
The optional gateway transport becomes enforceable only when the hosted entry point rejects direct provider credentials and receives a server-controlled output cap.
Acceptance uses the actual SDK and native process with a local gateway fixture so it exercises the deployed protocol without provider keys or paid tokens.
Release remains coordinated with the cloud gateway and a rebuilt runtime snapshot.
Changes
Testing
npm run checknpm run build:offlinepackages/coding-agent-server:node ../../node_modules/vitest/dist/cli.js --run test/gateway-runtime-process.test.tsnode --test scripts/runtime-image.test.mjs./test.sh, using the repository's isolated, non-E2E runner.packages/ai:node ../../node_modules/vitest/dist/cli.js --run test/together-models.test.ts test/generate-models-strict.test.ts: 7 tests passed after incorporating the catalog prerequisite.node --test scripts/vendored-braces-security.test.mjs: 11 tests passed against the inherited dependency patch.