Repository navigation
Conversation
jefft72
changed the base branch from
main
to
codex/token-pr-companion-00-catalog-fixtures
October 3, 2026 04:30
Pepps233
self-requested a review
October 4, 2026 18:02
Pepps233
added this pull request to stack #256
October 4, 2026 18:34
Update exact Undici, Vitest and coverage versions to the reviewed security patches and preserve the corresponding generated distribution locks. Keep the dependency-only review separate from hosted model behavior while maintaining one consistent source, installation and shipped CLI graph.
The shx dependency chain still uses braces 3.0.3, which can exhaust recursive AST walkers on deeply nested patterns and has no upstream patched release. Vendor the reviewed MIT source with fixed depth and AST-value guards under a transparent private version, scope its override to shx, copy it before Docker installation, and verify the real installed glob and CLI paths while preserving existing transport and test dependency patches.
Apply the reviewed local braces patch through a root override so npm 10 and npm 11 resolve it consistently across workspace build dependencies. Preserve the private package identity and unchanged generated lockfile, and document the current development-only consumer scope.
Pepps233
force-pushed
the
codex/token-pr-companion-01-deps
branch
from
October 4, 2026 18:35
91aceee to
f8a98ea
Compare
Pepps233
approved these changes
Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Review size: 1146 meaningful changed lines, plus 195 generated lockfile lines and 49 documentation lines, counted as additions plus deletions.
Base:
codex/token-pr-companion-00-catalog-fixtures; head:codex/token-pr-companion-01-deps.Updates runtime transport and test dependencies and fixes deeply nested build-tool glob patterns exhausting the brace parser's stack.
Fixes clean npm 10 installs reporting
Missing: braces@3.0.3 from lock fileby applying the private patch consistently across workspace dependencies.The vendored JavaScript, private package manifest, MIT license, configuration, and regression tests are included in the meaningful count.
Reasoning
Undici and Vitest patch pins and regenerated distribution locks keep source, installed runtime, and shipped CLI dependency graphs consistent.
GHSA-vfj7-8cjw-p6xm has no upstream patched release, so the existing development-tool shx dependency chain uses a reviewed local patch of braces 3.0.3 with a transparent private name and version.
The patch bounds structural recursion to 100 levels independently of caller options and checks caller-supplied AST values before coercion.
It preserves normal glob behavior and the existing build tools, with provenance and retirement instructions included beside the source.
Registry audit results do not independently establish the security of the private source; its review and regression coverage provide additional evidence.
The root override is required because npm 10 does not reliably propagate the ancestor-scoped override through workspace dependencies, causing clean CI installation to reject the unchanged lockfile.
The current affected consumer is shx; production distribution locks exclude this local development dependency.
Future braces consumers inherit the root override and require compatibility review.
The prerequisite isolates deterministic catalog tests and enables full hosted CI on every stacked head.
Changes
@diffex-cloud/braces@3.0.3-diffex.1, pinning its fill-range dependency to 7.1.1.Testing
npm ci --ignore-scriptsusing the unchanged generated lockfile passed under npm 10.9.9 and npm 11.16.0; both installed the private patch through the real shx dependency chain and passed all 11 security tests.npm run check, including all pin, distribution-lock, type, and browser checks.npm run build, using captured public provider responses with Together's DeepSeek-V4-Pro omitted.node --test scripts/vendored-braces-security.test.mjs: 11 tests passed.packages/ai:node ../../node_modules/vitest/dist/cli.js --run test/together-models.test.ts test/generate-models-strict.test.ts: 7 tests passed../test.sh, using the repository's credential-isolated runner.npm audit --jsonandnpm audit --omit=dev --json: zero registry-reported vulnerabilities.