Repository navigation
chore(release): reject packaged AGENTS.md - #215
Merged
Merged
Conversation
Prevent repository instructions from entering approved npm artifacts, including bundled workspaces and nested archives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject
AGENTS.mdin reviewed release archives, including case variants, bundled workspaces, and nested archives.The published
@diffexai/diffex@0.2.1tarball already contains no such file; this closes a missing enforcement check for future artifacts.Reasoning
Repository instructions must not ship in the installable CLI.
Four contaminated archive regressions passed the previous release gate, demonstrating that the existing package inventory checks did not enforce that requirement.
The existing recursive archive gate now rejects these files before publication while permitting documentation about user-owned context files.
Changes
AGENTS.mdpath components in the release payload checker.No runtime behavior, dependencies, package versions, or published artifact bytes change.
Live credential verification and the unresolved npm HTTP 400 are recorded separately in diffex-cloud#161.
Testing
npm run checkpassed after supported model-data hydration.node --test scripts/distribution-payload.test.mjs scripts/prepare-distribution.test.mjspassed all 26 tests.scripts/check-distribution-payload.pywith the new guard../test.shcompleted with one fresh-checkout setup failure: the fs.watch subprocess regression needed compiledpackages/tui/distfiles.Generated that dependency with
node_modules/.bin/tsgo -p packages/tui/tsconfig.build.json, then rerantest/suite/regressions/2791-fswatch-error-crash.test.tsfrom the coding-agent package: passed.All other workspace suites passed; credential-dependent tests remained skipped by the isolated test harness.