Skip to content

fix(evolution): evolution curation semantics and curation failures - #133

Merged
Pepps233 merged 4 commits into
mainfrom
fix/evolution-curation-semantics
Aug 27, 2026
Merged

Pepps233 merged 4 commits into
mainfrom
fix/evolution-curation-semantics

Conversation

@Pepps233

@Pepps233 Pepps233 commented Aug 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixes evolution-memory curation failures caused by inconsistent placement semantics.
Aligns the curator, writer, proposal schema, and runtime correction behavior.

Reasoning

The public contract and writer already treated a null/null ADD destination as global append, but the curator rejected it.

REPLACE also reused ADD placement after removal, which relocated replacement content.

Semantic validation ran outside the active model transcript, while the schema and exhausted-response classification disagreed with parser and request-stage behavior.

Changes

  • Accept and document null/null global append placement.
  • Make REPLACE preserve the original item and section location.
  • Reject missing named sections during blank-memory bootstrap.
  • Validate curator semantics inside the active transcript with aggregated decision and field-path diagnostics.
  • Bind proposal schema variants to valid target, action, delta, and finding combinations.
  • Classify exhausted curator responses as curation-invalid-response.
  • Run hosted server integration tests against current workspace sources.

Testing

  • node ../../node_modules/vitest/dist/cli.js --run test/evolution-memory-writer.test.ts test/curator.test.ts in packages/evolution
  • node ../../node_modules/vitest/dist/cli.js --run test/proposal-ranking.test.ts in packages/evolution
  • node ../../node_modules/vitest/dist/cli.js --run test/evolution-runtime.test.ts test/evolution-menu.test.ts in packages/coding-agent
  • node ../../node_modules/vitest/dist/cli.js --run test/websocket-flow.test.ts in packages/coding-agent-server
  • npm run check
  • ./test.sh

@Pepps233 Pepps233 self-assigned this Aug 27, 2026
@Pepps233 Pepps233 changed the title Fix evolution curation semantics fix(evolution): evolution curation semantics and curation failures Aug 27, 2026
- Keeps replacements at the original item and section location
- Rejects blank-memory sections instead of silently discarding them
- Corrects semantic errors inside the active model transcript
- Aligns schema variants and exhausted-response classification
- Runs hosted server tests against current workspace sources
- Prevents stale build artifacts from hiding integration failures
- Keeps PR 132 changelog content out of the rebased branch
- Restores the pre-PR 132 Unreleased section exactly
@Pepps233
Pepps233 force-pushed the fix/evolution-curation-semantics branch from 018eb61 to b81c07f Compare August 27, 2026 14:49
@Pepps233

Copy link
Copy Markdown
Contributor Author

Issue 1: PR 133 was based on main before PR 132 merged. Its history needed to be synchronized with the current base.
Resolved by commit sha 1: Commits a119633, 6451265, and 5648c3d were rebased onto main at 59dc0c6. Current main is now an ancestor of the PR head.

Issue 2: PR 132 added a Breaking Changes subsection and a unified skill catalog entry to the coding-agent CHANGELOG. Those entries needed to be excluded from PR 133.
Resolved by commit sha 2: Commit b81c07f removes exactly those five added lines. The resulting Unreleased section matches the pre-PR 132 file.

@Pepps233
Pepps233 merged commit 542517d into main Aug 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant