Conversation
agissept
force-pushed
the
pre-release/4.2.104
branch
from
September 26, 2026 03:09
aa0077e to
785d318
Compare
agissept
force-pushed
the
pre-release/4.2.105
branch
from
September 26, 2026 03:09
09d5805 to
b0e3444
Compare
agissept
force-pushed
the
pre-release/4.2.104
branch
from
September 26, 2026 03:17
785d318 to
e497ac9
Compare
agissept
force-pushed
the
pre-release/4.2.105
branch
from
September 26, 2026 03:18
b0e3444 to
587cc76
Compare
v13 replaces the whole component (flip-only): Translator now implements
Contracts\Translation\Translator (drops Symfony TranslatorInterface + trans()/
transChoice()); LoaderInterface -> Contracts\Translation\Loader; Interval/
PluralizationRules fold into MessageSelector. v13 Translation\* shadows the fork
tree via the PSR-4 seed mechanism.
- composer: illuminate/translation self.version -> ^13 (v13.33.0).
- Foundation\Application shims for the v13 TranslationServiceProvider:
* getFallbackLocale() (v13 provider reads it; L4.2 fork lacked it).
* bind 'path.lang' (=> path/lang) in bindInstallPaths (v13 FileLoader reads path.lang).
Both ponytail-marked, remove at Foundation swap.
- Validation is still fork-owned and coupled to the translator: Factory/Validator
type-hinted Symfony\Contracts\Translation\TranslatorInterface (v13 Translator no longer
implements it) and Validator called $translator->trans() (removed in v13). Repoint the
import to Illuminate\Contracts\Translation\Translator (aliased) and trans() -> get()
(5 sites). Fixed the fork Validation tests accordingly (v13 Translator + addResource
shim; mocks retargeted to the Illuminate contract).
- Drop tests/Translation/{TranslationTranslatorTest,TranslationFileLoaderTest} (vendored
behavior: mocked the old Illuminate\Translation\LoaderInterface / fork Translator ctor).
Fork suite 527 green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
agissept
force-pushed
the
pre-release/4.2.104
branch
from
September 26, 2026 03:37
e497ac9 to
b1d543a
Compare
agissept
force-pushed
the
pre-release/4.2.105
branch
from
September 26, 2026 03:37
587cc76 to
c39b1ee
Compare
agissept
marked this pull request as draft
September 26, 2026 04:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 4.3 (L2 per-unit): swap
illuminate/translation→^13(flip-only). Stacked di atas #75 (4.2.104 log).Perubahan
illuminate/translationreplace→require ^13(v13.33.0). v13Translation\*shadow tree fork (PSR-4 seed).TranslatorimplementContracts\Translation\Translator(buang SymfonyTranslatorInterface+trans()/transChoice());LoaderInterface→Contracts\Translation\Loader;Interval/PluralizationRuleslebur keMessageSelector.Foundation\Applicationuntuk v13TranslationServiceProvider:getFallbackLocale()+ bindpath.lang(=> path/lang) dibindInstallPaths. Keduanyaponytail:-marked, dicabut saat Foundation swap.Factory/Validatortype-hint SymfonyTranslatorInterface(v13 tak implement) +Validatorpanggil->trans()(dihapus v13) → repoint import keIlluminate\Contracts\Translation\Translator(aliased) +trans()→get()(5 titik). Test Validation fork disesuaikan (v13 Translator +addResourceshim; mock ke Illuminate contract).tests/Translation/{TranslationTranslatorTest,TranslationFileLoaderTest}(vendored-behavior).Fork suite 527 hijau.
App matched-pair: dicoding#5914.