Conversation
agissept
force-pushed
the
pre-release/4.2.103
branch
from
September 26, 2026 03:09
43ba22b to
8d97dd4
Compare
agissept
force-pushed
the
pre-release/4.2.102
branch
from
September 26, 2026 03:17
4fd1d85 to
1d35c43
Compare
agissept
force-pushed
the
pre-release/4.2.103
branch
from
September 26, 2026 03:17
8d97dd4 to
935511a
Compare
v13 Config\Repository ctor is (array $items) — the L4.2 (LoaderInterface, $env)
loader/env-cascade API is gone. Keep the fork FileLoader (falls back via PSR-4
seed mechanism; v13 config ships no loader) and eagerly load every config group —
base + env-cascade overlay — into the array at bootstrap.
- composer: illuminate/config self.version -> ^13.
- Foundation/start.php: build the pre-loaded array from FileLoader::load() per group
(union of config/*.php and config/{env}/*.php basenames) -> new Repository($items).
- Drop ConfigRepositoryTest (asserted removed fork internals: loader ctor, package(),
addNamespace()); ConfigFileLoaderTest kept (FileLoader still fork-owned).
- RoutingIntegrationTest setUp: new Repository() (array ctor) instead of loader mock.
Fork suite 586 green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
agissept
force-pushed
the
pre-release/4.2.103
branch
from
September 26, 2026 03:37
935511a to
1a1f69f
Compare
agissept
marked this pull request as draft
September 26, 2026 04:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 4.3 (L2 per-unit): swap
illuminate/config→^13. Stacked di atas #73 (4.2.102 console).Perubahan
illuminate/configdarireplace→require ^13(v13.33.0).Config\Repositoryctor(array $items)menggantikan L4.2(LoaderInterface, $env).Foundation/start.phpkini eager-load tiap config group ke array: union basenameconfig/*.php+config/{env}/*.php, tiap group viaFileLoader::load($env, $group)(env-cascade tetap terjaga).src/Illuminate/Config/.ConfigRepositoryTest(asserted removed fork internals: loader ctor,package(),addNamespace()).ConfigFileLoaderTestdipertahankan (FileLoader masih fork).RoutingIntegrationTest::setUp:new Repository()(array ctor) ganti loader-mock.Fork suite 586 hijau.
App matched-pair: dicoding#5912.