Pre-release 4.2.102 → 4.2.101 — task 4.2 console swap (illuminate/console ^13)

composer.json

@@ -13,8 +13,29 @@
         "php": ">=8.4.23",
         "d11wtq/boris": "~1.0",
         "filp/whoops": "~2.11",
+        "illuminate/bus": "^13",
+        "illuminate/cache": "^13",
+        "illuminate/collections": "^13",
+        "illuminate/conditionable": "^13",
+        "illuminate/console": "^13",
+        "illuminate/container": "^13",
+        "illuminate/contracts": "^13",
+        "illuminate/cookie": "^13",
+        "illuminate/database": "^13",
+        "illuminate/encryption": "^13",
+        "illuminate/events": "^13",
+        "illuminate/filesystem": "^13",
+        "illuminate/http": "^13",
+        "illuminate/macroable": "^13",
+        "illuminate/pagination": "^13",
+        "illuminate/pipeline": "^13",
+        "illuminate/redis": "^13",
+        "illuminate/reflection": "^13",
+        "illuminate/session": "^13",
+        "illuminate/support": "^13",
+        "illuminate/view": "^13",
         "ircmaxell/password-compat": "~1.0",
-        "laravel/serializable-closure": "^1.2",
+        "laravel/serializable-closure": "^2.0.10",
         "monolog/monolog": "^3.10",
         "nesbot/carbon": "^3.8.4",
         "opis/closure": "~3.6",
@@ -38,31 +59,17 @@
     },
     "replace": {
         "illuminate/auth": "self.version",
-        "illuminate/cache": "self.version",
         "illuminate/config": "self.version",
-        "illuminate/console": "self.version",
-        "illuminate/container": "self.version",
-        "illuminate/cookie": "self.version",
-        "illuminate/database": "self.version",
-        "illuminate/encryption": "self.version",
-        "illuminate/events": "self.version",
         "illuminate/exception": "self.version",
-        "illuminate/filesystem": "self.version",
         "illuminate/foundation": "self.version",
         "illuminate/hashing": "self.version",
-        "illuminate/http": "self.version",
         "illuminate/html": "self.version",
         "illuminate/log": "self.version",
         "illuminate/mail": "self.version",
-        "illuminate/pagination": "self.version",
         "illuminate/queue": "self.version",
-        "illuminate/redis": "self.version",
         "illuminate/routing": "self.version",
-        "illuminate/session": "self.version",
-        "illuminate/support": "self.version",
         "illuminate/translation": "self.version",
         "illuminate/validation": "self.version",
-        "illuminate/view": "self.version",
         "illuminate/workbench": "self.version"
     },
     "require-dev": {

src/Illuminate/Auth/AuthManager.php

@@ -18,11 +18,11 @@ protected function createDriver($driver)
 		// When using the remember me functionality of the authentication services we
 		// will need to be set the encryption instance of the guard, which allows
 		// secure, encrypted cookie values to get generated for those cookies.
-		$guard->setCookieJar($this->app['cookie']);
+		$guard->setCookieJar($this->container['cookie']);
 
-		$guard->setDispatcher($this->app['events']);
+		$guard->setDispatcher($this->container['events']);
 
-		return $guard->setRequest($this->app->refresh('request', $guard, 'setRequest'));
+		return $guard->setRequest($this->container->refresh('request', $guard, 'setRequest'));
 	}
 
 	/**
@@ -38,7 +38,7 @@ protected function callCustomCreator($driver)
 
 		if ($custom instanceof Guard) return $custom;
 
-		return new Guard($custom, $this->app['session.store']);
+		return new Guard($custom, $this->container['session.store']);
 	}
 
 	/**
@@ -50,7 +50,7 @@ public function createDatabaseDriver()
 	{
 		$provider = $this->createDatabaseProvider();
 
-		return new Guard($provider, $this->app['session.store']);
+		return new Guard($provider, $this->container['session.store']);
 	}
 
 	/**
@@ -60,14 +60,14 @@ public function createDatabaseDriver()
 	 */
 	protected function createDatabaseProvider()
 	{
-		$connection = $this->app['db']->connection();
+		$connection = $this->container['db']->connection();
 
 		// When using the basic database user provider, we need to inject the table we
 		// want to use, since this is not an Eloquent model we will have no way to
 		// know without telling the provider, so we'll inject the config value.
-		$table = $this->app['config']['auth.table'];
+		$table = $this->container['config']['auth.table'];
 
-		return new DatabaseUserProvider($connection, $this->app['hash'], $table);
+		return new DatabaseUserProvider($connection, $this->container['hash'], $table);
 	}
 
 	/**
@@ -79,7 +79,7 @@ public function createEloquentDriver()
 	{
 		$provider = $this->createEloquentProvider();
 
-		return new Guard($provider, $this->app['session.store']);
+		return new Guard($provider, $this->container['session.store']);
 	}
 
 	/**
@@ -89,9 +89,9 @@ public function createEloquentDriver()
 	 */
 	protected function createEloquentProvider()
 	{
-		$model = $this->app['config']['auth.model'];
+		$model = $this->container['config']['auth.model'];
 
-		return new EloquentUserProvider($this->app['hash'], $model);
+		return new EloquentUserProvider($this->container['hash'], $model);
 	}
 
 	/**
@@ -101,7 +101,7 @@ protected function createEloquentProvider()
 	 */
 	public function getDefaultDriver()
 	{
-		return $this->app['config']['auth.driver'];
+		return $this->container['config']['auth.driver'];
 	}
 
 	/**
@@ -112,7 +112,7 @@ public function getDefaultDriver()
 	 */
 	public function setDefaultDriver($name)
 	{
-		$this->app['config']['auth.driver'] = $name;
+		$this->container['config']['auth.driver'] = $name;
 	}
 
 }

src/Illuminate/Auth/AuthServiceProvider.php

@@ -18,7 +18,7 @@ class AuthServiceProvider extends ServiceProvider {
 	 */
 	public function register()
 	{
-		$this->app->bindShared('auth', function($app)
+		$this->app->singleton('auth', function($app)
 		{
 			// Once the authentication service has actually been requested by the developer
 			// we will set a variable in the application indicating such. This helps us

src/Illuminate/Auth/Console/ClearRemindersCommand.php

@@ -23,7 +23,7 @@ class ClearRemindersCommand extends Command {
 	 *
 	 * @return void
 	 */
-	public function fire()
+	public function handle()
 	{
 		$this->laravel['auth.reminder.repository']->deleteExpired();
 

src/Illuminate/Auth/Console/RemindersControllerCommand.php

@@ -45,7 +45,7 @@ public function __construct(Filesystem $files)
 	 *
 	 * @return void
 	 */
-	public function fire()
+	public function handle()
 	{
 		$destination = $this->getPath() . '/RemindersController.php';
 

src/Illuminate/Auth/Console/RemindersTableCommand.php

@@ -44,7 +44,7 @@ public function __construct(Filesystem $files)
 	 *
 	 * @return void
 	 */
-	public function fire()
+	public function handle()
 	{
 		$fullPath = $this->createBaseMigration();
 

src/Illuminate/Auth/Reminders/ReminderServiceProvider.php

@@ -36,7 +36,7 @@ public function register()
 	 */
 	protected function registerPasswordBroker()
 	{
-		$this->app->bindShared('auth.reminder', function($app)
+		$this->app->singleton('auth.reminder', function($app)
 		{
 			// The reminder repository is responsible for storing the user e-mail addresses
 			// and password reset tokens. It will be used to verify the tokens are valid
@@ -65,7 +65,7 @@ protected function registerPasswordBroker()
 	 */
 	protected function registerReminderRepository()
 	{
-		$this->app->bindShared('auth.reminder.repository', function($app)
+		$this->app->singleton('auth.reminder.repository', function($app)
 		{
 			$connection = $app['db']->connection();
 
@@ -89,17 +89,17 @@ protected function registerReminderRepository()
 	 */
 	protected function registerCommands()
 	{
-		$this->app->bindShared('command.auth.reminders', function($app)
+		$this->app->singleton('command.auth.reminders', function($app)
 		{
 			return new RemindersTableCommand($app['files']);
 		});
 
-		$this->app->bindShared('command.auth.reminders.clear', function()
+		$this->app->singleton('command.auth.reminders.clear', function()
 		{
 			return new ClearRemindersCommand;
 		});
 
-		$this->app->bindShared('command.auth.reminders.controller', function($app)
+		$this->app->singleton('command.auth.reminders.controller', function($app)
 		{
 			return new RemindersControllerCommand($app['files']);
 		});

src/Illuminate/Cache/CacheServiceProvider.php

@@ -18,17 +18,17 @@ class CacheServiceProvider extends ServiceProvider {
 	 */
 	public function register()
 	{
-		$this->app->bindShared('cache', function($app)
+		$this->app->singleton('cache', function($app)
 		{
 			return new CacheManager($app);
 		});
 
-		$this->app->bindShared('cache.store', function($app)
+		$this->app->singleton('cache.store', function($app)
 		{
 			return $app['cache']->driver();
 		});
 
-		$this->app->bindShared('memcached.connector', function()
+		$this->app->singleton('memcached.connector', function()
 		{
 			return new MemcachedConnector;
 		});
@@ -43,12 +43,12 @@ public function register()
 	 */
 	public function registerCommands()
 	{
-		$this->app->bindShared('command.cache.clear', function($app)
+		$this->app->singleton('command.cache.clear', function($app)
 		{
 			return new Console\ClearCommand($app['cache'], $app['files']);
 		});
 
-		$this->app->bindShared('command.cache.table', function($app)
+		$this->app->singleton('command.cache.table', function($app)
 		{
 			return new Console\CacheTableCommand($app['files']);
 		});

src/Illuminate/CachedRouting/RoutingServiceProvider.php

@@ -56,7 +56,7 @@ public function register()
      */
     protected function registerRouter()
     {
-        $this->app['router'] = $this->app->share(
+        $this->app->singleton('router', 
             function ($app) {
                 $router = new Router($app['events'], $app);
 

src/Illuminate/Console/Application.php

@@ -22,6 +22,27 @@ class Application extends \Symfony\Component\Console\Application {
 	 */
 	protected $laravel;
 
+	/**
+	 * Callbacks to run when a console application is starting.
+	 *
+	 * ponytail: BC shim for v13 Support\ServiceProvider::commands(), which calls
+	 * Illuminate\Console\Application::starting(). Remove when console swaps to v13 (task 4.2/4.3).
+	 *
+	 * @var callable[]
+	 */
+	protected static $startingCallbacks = array();
+
+	/**
+	 * Register a callback to run when the console application is starting.
+	 *
+	 * @param  callable  $callback
+	 * @return void
+	 */
+	public static function starting($callback)
+	{
+		static::$startingCallbacks[] = $callback;
+	}
+
 	/**
 	 * Create and boot a new Console application.
 	 *
@@ -51,6 +72,11 @@ public static function make($app)
 
 		$app->instance('artisan', $console);
 
+		foreach (static::$startingCallbacks as $callback)
+		{
+			$callback($console);
+		}
+
 		return $console;
 	}
 
@@ -153,7 +179,19 @@ public function resolveCommands($commands)
 
 		foreach ($commands as $command)
 		{
-			$this->resolve($command);
+			try
+			{
+				$this->resolve($command);
+			}
+			catch (\Throwable $e)
+			{
+				// ponytail: some v13 components (session/cache/…) register console commands
+				// that extend v13 console base classes absent from the not-yet-swapped fork
+				// console. Skip the ones that can't load so artisan still boots; they return
+				// with the console swap (task 4.2). Commands that load fine still register.
+				error_log('[l13] skipped unresolvable console command '
+					. (is_string($command) ? $command : gettype($command)) . ': ' . $e->getMessage());
+			}
 		}
 	}
 

src/Illuminate/Console/Command.php

@@ -63,6 +63,19 @@ public function __construct()
 		$this->specifyParameters();
 	}
 
+	/**
+	 * ponytail: BC shim — exists so v13 component commands that declare
+	 * `#[\Override] configureDefaults()` (against the v13 console Command) can load under
+	 * the not-yet-swapped fork console. The fork configures via the constructor /
+	 * specifyParameters() instead, so this is a no-op. Remove at the console swap (task 4.2).
+	 *
+	 * @return void
+	 */
+	protected function configureDefaults()
+	{
+		//
+	}
+
 	/**
 	 * Specify the arguments and options on the command.
 	 *

src/Illuminate/Console/MigrationGeneratorCommand.php

@@ -0,0 +1,39 @@
+<?php namespace Illuminate\Console;
+
+/**
+ * ponytail: BC shim for v13's Illuminate\Console\MigrationGeneratorCommand. The fork
+ * console is not swapped yet (task 4.2), but v13 component commands (make:session-table,
+ * make:cache-table) extend this base — without it their class declaration fatals and
+ * breaks artisan boot. This lets them load; actual migration generation needs the v13
+ * console and is out of scope until the console swap. Remove then.
+ */
+abstract class MigrationGeneratorCommand extends Command {
+
+	/**
+	 * Get the migration table name.
+	 *
+	 * @return string
+	 */
+	abstract protected function migrationTableName();
+
+	/**
+	 * Get the path to the migration stub file.
+	 *
+	 * @return string
+	 */
+	abstract protected function migrationStubFile();
+
+	/**
+	 * Execute the console command.
+	 *
+	 * @return int
+	 */
+	public function handle()
+	{
+		if (method_exists($this, 'error')) {
+			$this->error('make:*-table generators require the v13 console (L13 migration task 4.2).');
+		}
+
+		return 1;
+	}
+}