fix: avoid NaN in pivot table AVERAGE totals - #1866
Open
janhenrikoverland wants to merge 1 commit into
Open
janhenrikoverland wants to merge 1 commit into
janhenrikoverland wants to merge 1 commit into
Conversation
Reporting rates come back with a factor but empty multiplier and divisor, which made all AVERAGE totals NaN. Fall back to the factor when multiplier is missing, and show N/A instead of NaN when the total still can't be computed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pivot tables with reporting rates show NaN in all totals.
The response has `factor: 100` but empty `multiplier` and `divisor`, so the AVERAGE total ends up as `x * undefined` = NaN.
Changes
Note
This makes the Reporting rate totals correct, but Actual reports and Expected reports totals are still wrong because the backend returns `totalAggregationType: AVERAGE` for them (they should be `SUM`). The backend should also return `multiplier`/`divisor` for reporting rates. That needs a backend fix.
🤖 Generated with Claude Code