Conversation
PEM keys, delegation chains and the `--output-seed` recovery phrase were written with plain `fs::write`, so under a typical umask of 022 they came out world-readable (0644) inside world-listable directories (0755). Add `fs::write_private`, which creates the file 0600 and narrows an existing one before writing to it, and `fs::create_private_dir_all`, which makes the directory 0700 even if it already existed. Use them for every identity key write, the `keys/` and `delegations/` directories, and the seed file.
raymondk
added this pull request to stack #797
September 25, 2026 23:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEM keys, delegation chains and the
--output-seedrecovery phrase were written with plainfs::write, so under a typical umask of 022 they came out world-readable (0644) inside world-listable directories (0755).