fix: reject path-like network and environment names - #795
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The changelog does not clearly disclose the breaking manifest restriction, and the validation documentation is stale.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Rejects unsafe network and environment names before they become filesystem path components.
Changes:
- Adds validation and dedicated errors for invalid names.
- Adds regression coverage for path-like names.
- Adds an Unreleased changelog entry.
| File | Description |
|---|---|
crates/icp-project/src/project.rs |
Validates names and tests rejected inputs. |
CHANGELOG.md |
Records the behavior change. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| # Unreleased | ||
|
|
||
| fix: reject path-like network and environment names |
Collaborator
Author
There was a problem hiding this comment.
I think it's fine to leave this as non breaking.
Comment on lines
+336
to
+338
| /// archive paths — so no per-site sanitizing is needed. Network and environment | ||
| /// names are held to it too, since each becomes a path component under `.icp` | ||
| /// (and `/`, `..` or an absolute name would escape it). In particular `:` is the |
Network and environment names are used as path components under `.icp` (the network's state directory and `<env>.ids.json`), but were never validated. Hold both to the same rule canister names already follow: non-empty, ASCII letters, digits, `_` and `-` only.
raymondk
force-pushed
the
fix/validate-network-environment-names
branch
from
September 25, 2026 23:40
442cb68 to
ebd1b5c
Compare
raymondk
added this pull request to stack #797
September 25, 2026 23:42
lwshang
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.