Repository navigation
fix: keep DTMF senders alive and observers of other wrappers registered - #458
Merged
Merged
Conversation
getDtmfSender() handed out a pointer it held no reference on, so using the DTMF sender after the connection had closed and the RTCRtpSender was disposed crashed the VM. The Java object now holds a reference, released by the new RTCDtmfSender.dispose(). Unregistering or disposing one wrapper of a DTLS transport, sender, receiver or DTMF sender removed the observer another wrapper of the same native object had registered since. A process-wide registry now records which observer is registered, and a wrapper only unregisters its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getDtmfSender()handed out a pointer it held no reference on, so using the DTMF sender after the connection had closed and theRTCRtpSenderwas disposed crashed the VM. The Java object now holds a reference, released by the newRTCDtmfSender.dispose().