Repository navigation
Expense category descriptions - #208
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Expense categories now have a description, taken from the wording of the Elster form "Anlage EÜR, 4 – 2. Betriebsausgaben", so it's easier to choose the category that is correct for the tax return.
ExpenseCategoryimplements Filament'sHasDescriptioncontract with a translatedgetDescription()method (en/de). The minor-assets limit in its text is read fromconfig('business.minor_assets.max_net').While mapping the categories to the EÜR lines, it turned out that the
Vatcategory was missing from the tax return widget:TaxReturnFormInputhas two new rows:Vatexpenses.Vatexpenses, shown as a positive amount. Negative entries are already created byExpense::saveLastAdvanceVat()in refund months.taxabletoggle is disabled and saved asfalsewhen a tax category (Vat,Tax) is selected. A tax payment or refund contains no VAT itself, and a taxable entry would only report its net amount on line 58/18.Also fixes the three remaining Pint formatting issues (method ordering and line wrapping only, no behaviour change).
Benefits
Applicable Issues
Closes #203