Repository navigation
Add offtime date validation - #207
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
The offtime form now prevents invalid date ranges. The end date is validated to be after the start date (
->after('start')) and remains optional for single-day offtimes. When both dates are set and the start date changes, the end date is automatically moved to the day after the new start date. The offtime factory now always generates an end date at least one day after the start, so tests don't randomly fail the new validation. Tests cover the validation, the automatic adjustment and an empty end date staying empty.Benefits
Offtimes with an end date before or on their start date can no longer be saved, and changing the start date keeps the range valid without editing the end date by hand.
Applicable Issues
Closes #202