Skip to content

compiler: Skip CondEq snapshot shift when the point is on the factor grid - #3043

Open
mloubout wants to merge 1 commit into
mainfrom
fix-condeq-factor-shift
Open

mloubout wants to merge 1 commit into
mainfrom
fix-condeq-factor-shift

Conversation

@mloubout

@mloubout mloubout commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.26%. Comparing base (00865f8) to head (a9964bb).

Files with missing lines Patch % Lines
devito/types/relational.py 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3043      +/-   ##
==========================================
+ Coverage   84.25%   84.26%   +0.01%     
==========================================
  Files         258      258              
  Lines       56955    56982      +27     
  Branches     4851     4854       +3     
==========================================
+ Hits        47989    48018      +29     
+ Misses       8139     8138       -1     
+ Partials      827      826       -1     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.56% <50.00%> (-0.02%) ⬇️
pytest-gpu-gcc- 79.03% <94.44%> (+<0.01%) ⬆️
pytest-gpu-icx- 78.99% <94.44%> (+0.03%) ⬆️
pytest-gpu-nvc-nvidiaX 69.14% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

"""
Infer shift incurred by the expression. Generally only
applies when a CondEq is used as it adds a single value.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding an example to this docstring would be useful. I figured it out, but it wasn't super obvious

@mloubout
mloubout force-pushed the fix-condeq-factor-shift branch from 7daacb5 to a9964bb Compare October 10, 2026 16:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants