Skip to content

Flatten the welcome email on phones and drop the repeated welcome line - #204

Merged
devhims merged 1 commit into
mainfrom
fix/welcome-email-mobile-layout
Oct 16, 2026
Merged

devhims merged 1 commit into
mainfrom
fix/welcome-email-mobile-layout

Conversation

@devhims

@devhims devhims commented Oct 16, 2026

Copy link
Copy Markdown
Owner

Summary

Three changes to the welcome email, prompted by how it looked in Gmail on Android:

  • One frame on phones. The page inset and the card's rounded border nested a second frame around the text, which cost width and pushed the body down. Below 620px the page padding is now 0, the card has no border or radius, and its padding drops from 28px 20px to 24px 18px. The space under the logo row drops from 40px to 28px. Desktop is unchanged.
  • No repeated welcome line. "Welcome to video2ctx, {name}." repeated the subject line, so it is removed. The headline now carries the spacing before "Hi {name}," (36px on desktop, 24px on phones).
  • Copy. The opening paragraph now reads "agents are still bad at video, especially long ones."

Testing

  • An earlier build with the same layout and copy (before rebasing onto the smaller phone type scale from Use a smaller type scale for the welcome email on phones #194) was sent through Email Sending to a Gmail address for review on Android.
  • Rendered at 390px in dark mode: one full-width surface, with "Hi {name}," starting just below the headline.
  • npx vitest run test/welcome-email.test.ts test/notification-email.test.ts test/auth-config.test.ts: 23 passed. The no-name test no longer expects the removed welcome line.

…me line

On phones the page inset and card border nested a second frame around the
text. Below 620px the card now fills the width with no border or radius,
and its padding drops to 24px 18px.

The intro line repeated the subject, so it is removed and the headline
carries its spacing. The opening paragraph now says agents are especially
bad at long videos.
@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
video2ctx-web Ready Ready Preview Oct 16, 2026 4:37am UTC

devhims commented Oct 16, 2026

Copy link
Copy Markdown
Owner Author

Review: APPROVE

Reviewed exact head 9b877482d831a53d0ccc12068e5a9c7321a90e59 against 2e2e5c8e9b145c7d744a8375bdb11db293dd8415. No blocking correctness or security findings.

Independent checks passed:

  • All 23 tests across welcome-email, notification-email and auth-config.
  • Additional render checks for first-token markup escaping, URL attribute escaping, blank-name fallback and removal of the repeated welcome sentence.
  • Chromium at 320, 390, 600, 620, 621 and 800px in light/dark modes: no horizontal overflow; intended padding, border and spacing changes applied.
  • Readable inline fallback with stylesheet blocks removed; git diff --check clean.
  • Final head unchanged; all eight jobs in Verify run 38851595002 now passed, alongside the Vercel preview.

Nonblocking observations:

  • Low, test coverage: platform/test/welcome-email.test.ts:24 removes the obsolete assertion without adding regression checks for the removed greeting or new mobile layout rules. Adding these would help catch future accidental reversions. The independent render checks passed today.
  • Low, wording/layout boundary: platform/src/lib/welcome-email.tsx:98 retains the card's 600px maximum width. At a 620px viewport this leaves 10px gutters rather than literally full-width. Normal phone widths tested fill correctly; no usability problem found.

Verification limits: local Chromium is not Gmail Android or Outlook. Automatic Gmail color inversion, Outlook's rendering engine and real CID attachment display were not independently tested. External browser requests were blocked during local rendering, so fallback fonts and an unresolved CID logo were used. No real emails were sent. These limits do not reveal a blocker in this small layout change.

@devhims
devhims merged commit 79841cb into main Oct 16, 2026
10 checks passed
@devhims
devhims deleted the fix/welcome-email-mobile-layout branch October 16, 2026 04:47

This branch was successfully deployed

1 active deployment
Preview — 9b877482 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant