Repository navigation
Flatten the welcome email on phones and drop the repeated welcome line - #204
Merged
Merged
Conversation
…me line On phones the page inset and card border nested a second frame around the text. Below 620px the card now fills the width with no border or radius, and its padding drops to 24px 18px. The intro line repeated the subject, so it is removed and the headline carries its spacing. The opening paragraph now says agents are especially bad at long videos.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
Review: APPROVEReviewed exact head Independent checks passed:
Nonblocking observations:
Verification limits: local Chromium is not Gmail Android or Outlook. Automatic Gmail color inversion, Outlook's rendering engine and real CID attachment display were not independently tested. External browser requests were blocked during local rendering, so fallback fonts and an unresolved CID logo were used. No real emails were sent. These limits do not reveal a blocker in this small layout change. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three changes to the welcome email, prompted by how it looked in Gmail on Android:
Testing
npx vitest run test/welcome-email.test.ts test/notification-email.test.ts test/auth-config.test.ts: 23 passed. The no-name test no longer expects the removed welcome line.