Repository navigation
fix: deliver full caption evidence to answers and cite moments - #203
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Changes needed — reviewed
Coverage: This addresses the coffee excerpt truncation and runway page loss, but does not fully resolve the observed sessions. Caption-window anchors still reproduce 512s instead of 529s and 1s instead of 16s. Photography’s camera-shake/motion-blur error and missing-source coverage are unchanged. Verified: 1,835 platform tests, 238 runtime integrations, 110 web tests, both builds and docs passed; 37 reviewer controls passed and 8 assertions reproduced the defects above. All eight Verify jobs passed. Synthetic local testing only; all four original flows still need live retesting after deployment. |
|
Changes needed — reviewed
The previous unsafe/safe and disconnected/reversed-window cases are fixed; ending fixtures now correctly link 529s and 16s. Older saved analyses are not automatically regenerated. Verified: 1,844 platform, 87 runtime integration and 110 web tests passed; platform build/docs passed. Independent controls: 48 passed, 13 failures reproducing these findings. All eight Verify jobs passed. Local mock testing only; the four observed flows still need live retesting, including unchanged visual-classification and missing-source behavior. |
|
Changes needed — reviewed
Verified: 1,853 platform, 151 integration and 110 web tests passed; platform build/docs passed. Additional controls: 18 passed, 15 failures reproducing these boundaries. All eight Verify jobs passed. Ending links remain correct at 529s/16s. Mock testing only; live QA behavior and automatic repair of older saved analyses remain unverified/out of scope. |
|
Changes needed — reviewed
Verified: 1,860 platform, 151 integration and 110 web tests passed; platform build/docs passed. Independent controls: 103 passed, 15 failing assertions reproduced these defects. All eight Verify jobs passed. Ending links remain correct at 529s/16s. Local mock testing only; live QA remains unverified, and older analyses are not automatically regenerated. |
Production sessions lost evidence before the answer: a session search hit was cut before the matching caption, and a follow-up read only part of a saved transcript. Inline citations also opened the whole video. - Transcript excerpts reach the finalizer at 2,000 characters, the analysis window size, instead of 800 (run 63ece937 lost "a sixteen to one" at character 835). Analysis packets still pass findings, not caption text. - get_video_transcript snaps a model-chosen offset to the start of its 5,000-caption page, so a read never drops earlier captions (run 0bb4aadb). Caching and continuation follow the page; traces keep the requested offset. - Inspect guidance asks correction follow-ups to read the saved transcript again, since research routes do not inherit earlier transcripts. This is prompt guidance and is not enforced. - Compact answers name the earliest cited moment per video ([1 · 4:52]); the dashboard links each timed reference to that moment.
02de1f5 to
5c4b53c
Compare
|
Approve — reviewed Independent checks confirm the coffee passage survives projection, paging preserves cache keys and requested-offset traces, and timed references resolve safely in the dashboard. Checker behavior matches baseline; the earlier quote/fraction additions were removed. Verified: 31 independent controls, 1,818 unit tests, 151 integrations and 110 web tests passed; platform build/docs passed. All eight Verify jobs passed. Limits: Mock/local testing; live correctness was not independently verified. Exact quotes, caption-level ending links (still 8:32/0:01), photography false flags and mandatory rereading remain explicitly deferred. |
Problem / Motivation
Production sessions lost evidence the session already held before the finalizer wrote its answer:
Inline citations also linked to the whole video, because compact answers collapse each citation group to a per-video source.
What changed
get_video_transcriptsnaps any offset to the start of its 5,000-caption page. A model-chosen offset returns the whole page; long transcripts page as before. Caching and continuation follow the page; traces keep the requested offset.[1 · 4:52]. Sources stay one per video. The dashboard links each timed reference to that moment.The transcript checker on main is unchanged. Earlier revisions added quote verification, fraction and ratio inference and quote anchors; review found repeated boundary defects, so that work is removed from this PR and will be redesigned separately.
Scope and limits
This fixes evidence delivery and improves reference presentation. It does not:
Tests
Build passed. Unit suite: 1,818 passed. Agent runtime, session and memory integration suites: 354 passed. Web tests: 110 passed. Docs check passed. The 12 new or updated tests fail on main's source: offset snapping and page continuation, the captured coffee search packet reaching the finalizer whole, and timed references across the backend and dashboard. One integration test now uses a genuine page boundary instead of offset 1.
Live replays with the exact user messages and production models (Fireworks GLM 5.3 Flash), three trials each on this commit:
Compact answer text changes from
[1]to[1 · m:ss]for timed references; the OpenAPI description is updated. Deploy the Worker and web app after merge. Production verification remains pending.