Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The mechanical signature updates are complete, compatible with the supported PHP version, and consistently applied across related contracts and implementations.
0 open findings
What changed in this PR
Updates public method signatures for PHP 8.4 nullable-parameter compatibility.
Changes:
- Adds explicit nullable types to optional string and callable parameters.
- Keeps interface, trait, base-class, and implementation signatures aligned.
- Documents the compatibility fix in the changelog.
| File | Description |
|---|---|
src/Interfaces/Groupable.php |
Updates the cloning contract. |
src/Group.php |
Updates nullable group parameters. |
src/Field.php |
Updates core field and RediPress parameters. |
src/Field/TrueFalse.php |
Updates constructor parameters. |
src/Field/PseudoGroup.php |
Updates clone parameters. |
src/Field/PostExcerpt.php |
Updates constructor parameters. |
src/Field/PostContent.php |
Updates constructor parameters. |
src/Field/Message.php |
Updates constructor parameters. |
src/Field/MediumEditor.php |
Updates constructor parameters. |
src/Field/GroupableField.php |
Updates constructor and clone parameters. |
src/Field/GoogleMap.php |
Updates constructor parameters. |
src/Field/Flexible/Layout.php |
Updates constructor and clone parameters. |
src/Field/DatePicker.php |
Updates constructor parameters. |
src/Field/Common/Groupable.php |
Updates the shared clone implementation. |
CHANGELOG.md |
Records the PHP 8.4 compatibility fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHP 8.4 deprecations by explicitly marking implicitly nullable parameters as nullable.